Fix hue for rgb colors if saturation was zero #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If saturation is exacly zero, we loose information for hue, since it will evaluate to zero if converted back from rgb. Setting saturation to a very tiny number solves this.
mgreter
force-pushed
the
bugfix/rgb-hue-from-zero-saturation
branch
from
e0b5b13 to
9adf7b7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If saturation is exacly zero, we loose information for hue,
since it will evaluate to zero if converted back from rgb.
Setting saturation to a very tiny number solves this.
Sass spec PR: sass/sass-spec#885
test { hue: hue(hsl(50, 0%, 30%)); hue: hue(hsl(100, 0%, 80%)); }